Don't switch to problem tab automatically in Manuscript build

novelwriter/manuscript/manuscript.py

@@ -424,13 +424,9 @@ class GuiManuscript(NToolDialog):
             self.buildStats.updateStats(buildObj.textStats, withDialog)
             self.buildProblems.updateProblems(buildObj.textProblems)
 
-            pIndex = self.detailsTabs.indexOf(self.buildProblems)
-            hasProblems = self.buildProblems.hasProblems()
-            if hasProblems and not self.detailsTabs.isTabVisible(pIndex):
-                self.detailsTabs.setTabVisible(pIndex, True)
-                self.detailsTabs.setCurrentIndex(pIndex)
-            elif not hasProblems:
-                self.detailsTabs.setTabVisible(pIndex, False)
+            self.detailsTabs.setTabVisible(
+                self.detailsTabs.indexOf(self.buildProblems), self.buildProblems.hasProblems()
+            )
             self.docPreview.setProblemCount(self.buildProblems.problemCount())
 
             self._updateCountsLabel(buildObj.textStats, withDialog)

tests/manuscript/test_manuscript.py

@@ -373,16 +373,11 @@ def testGuiManuscript_Features(
     SHARED.project.storage.getDocument(C.hSceneDoc).writeDocument("### New Scene\n\nText <A> <X>\n\n")
     manus._generatePreview()
     assert tabs.isTabVisible(tabs.indexOf(problems)) is True
-    assert tabs.currentWidget() is problems
+    assert tabs.currentWidget() is not problems
     assert problems.hasProblems() is True
     assert problems.problemCount() == 1
     assert manus.docPreview.ageLabel.text().endswith(", Problems: 1")
 
-    # The tab isn't selected again if it was already visible
-    tabs.setCurrentWidget(manus.buildOutline)
-    manus._generatePreview()
-    assert tabs.currentWidget() is manus.buildOutline
-
     parent = problems.listView.topLevelItem(0)
     assert parent is not None
     assert parent.text(0) == "Missing Auto-Replace Keys (1)"